Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] strict() modifier should come before optional/nullable #137

Merged
merged 2 commits into from
May 24, 2023
Merged

[Fix] strict() modifier should come before optional/nullable #137

merged 2 commits into from
May 24, 2023

Conversation

tvillaren
Copy link
Collaborator

Why

The strict() modifier, when applied to a subtype (e.g. an interface property), should be applied before optional() and nullable() (otherwise Zod will raise type validation errors).

This PR fixes it.

fabien0102
fabien0102 approved these changes May 24, 2023
View reviewed changes
Copy link
Owner

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@fabien0102 fabien0102 merged commit f8be6bd into fabien0102:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabien0102 fabien0102 fabien0102 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvillaren @fabien0102